feat: ${buildVersion} macro in artifactName config

Close #1527
electron-userland · May 4, 2017 · 23f0b37 · 23f0b37
1 parent 78d9b33
commit 23f0b37
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/docs/Options.md b/docs/Options.md
@@ -55,6 +55,7 @@ You can use macros in the file patterns, artifact file name patterns and publish
 * `${productName}` — [Sanitized](https://www.npmjs.com/package/sanitize-filename) product name.
 * `${version}`
 * `${env.ENV_NAME}` — any environment variable.
+* Any property of [AppInfo](https://github.com/electron-userland/electron-builder/wiki/electron-builder#AppInfo) (e.g. `buildVersion`, `buildNumber`).
 
 ## Source and Destination Directories
 You may also specify custom source and destination directories by using JSON objects instead of simple glob patterns.

diff --git a/packages/electron-builder/src/platformPackager.ts b/packages/electron-builder/src/platformPackager.ts
@@ -357,12 +357,6 @@ export abstract class PlatformPackager<DC extends PlatformSpecificBuildOptions>
     const appInfo = this.appInfo
     return pattern.replace(/\$\{([_a-zA-Z./*]+)\}/g, (match, p1): string => {
       switch (p1) {
-        case "name":
-          return appInfo.name
-
-        case "version":
-          return appInfo.version
-
         case "productName":
           return appInfo.productFilename
 
@@ -377,6 +371,10 @@ export abstract class PlatformPackager<DC extends PlatformSpecificBuildOptions>
           return this.platform.buildConfigurationKey
 
         default:
+          if (p1 in appInfo) {
+            return (<any>appInfo)[p1]
+          }
+
           if (p1.startsWith("env.")) {
             const envName = p1.substring("env.".length)
             const envValue = process.env[envName]