From 032ba05140eab92f1a9b31ed72236c639b455417 Mon Sep 17 00:00:00 2001 From: develar Date: Tue, 10 May 2016 09:14:57 +0200 Subject: [PATCH] feat: Code signing windows app using SHA256 Closes #386 --- README.md | 5 ++--- package.json | 4 ++-- src/winPackager.ts | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 1e480d125bb..87663428964 100755 --- a/README.md +++ b/README.md @@ -7,9 +7,8 @@ Complete solution to build ready for distribution and "auto update" installers o * [Build version management](#build-version-management). * [Publishing artifacts to GitHub Releases](https://github.com/electron-userland/electron-builder/wiki/Publishing-Artifacts). -[electron-packager](https://github.com/electron-userland/electron-packager), -[appdmg](https://github.com/LinusU/node-appdmg) and -[windows-installer](https://github.com/electron/windows-installer) are used under the hood. +[electron-packager](https://github.com/electron-userland/electron-packager) and +[appdmg](https://github.com/LinusU/node-appdmg) are used under the hood. Real project example — [onshape-desktop-shell](https://github.com/develar/onshape-desktop-shell). diff --git a/package.json b/package.json index e02d55a6648..cb1dcb1badc 100644 --- a/package.json +++ b/package.json @@ -66,7 +66,7 @@ "deep-assign": "^2.0.0", "electron-osx-sign-tf": "0.4.0-beta.0", "electron-packager-tf": "^7.0.2-beta.0", - "electron-winstaller-fixed": "~2.4.0-beta.1", + "electron-winstaller-fixed": "~2.5.0", "fs-extra-p": "^1.0.1", "globby": "^4.0.0", "hosted-git-info": "^2.1.4", @@ -101,7 +101,7 @@ "json-parse-helpfulerror": "^1.0.3", "path-sort": "^0.1.0", "plist": "^1.2.0", - "pre-git": "^3.8.3", + "pre-git": "^3.8.4", "semantic-release": "^4.3.5", "should": "^8.3.1", "ts-babel": "^0.8.6", diff --git a/src/winPackager.ts b/src/winPackager.ts index 5fa42dadb82..00d476afa7c 100644 --- a/src/winPackager.ts +++ b/src/winPackager.ts @@ -140,7 +140,7 @@ export class WinPackager extends PlatformPackager { usePackageJson: false, noMsi: true, extraFileSpecs: this.extraNuGetFileSources == null ? null : ("\n" + (await this.extraNuGetFileSources).join("\n")), - extraMetadataSpecs: projectUrl == null ? null : `\n${projectUrl}`, + extraMetadataSpecs: projectUrl == null ? null : `\n ${projectUrl}`, sign: { name: this.appName, site: projectUrl,