Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage mksquashfs binary does not support LZO compression #45

Closed
om26er opened this issue Sep 5, 2021 · 3 comments
Closed

AppImage mksquashfs binary does not support LZO compression #45

om26er opened this issue Sep 5, 2021 · 3 comments

Comments

@om26er
Copy link

om26er commented Sep 5, 2021

The mksquashfs binary is too old (https://github.com/electron-userland/electron-builder-binaries/blob/master/AppImage/linux-x64/mksquashfs), it does not support lzo compression, please build it with LZO compression and publish a new version.

Background: I am trying to enable electron-builder to support LZO compression for snap packages electron-userland/electron-builder#6201 and I recently found that electron builder internally uses the mksquashfs binary from this repository. Below are the logs

om26er@RemotePC:~/scm/ubuntu/electron-quick-start$ node /home/om26er/scm/ubuntu/electron-builder/packages/electron-builder/cli.js -l snap
  • electron-builder  version=22.13.1 os=5.11.0-31-generic
  • loaded configuration  file=/home/om26er/scm/ubuntu/electron-quick-start/electron-builder.yml
  • writing effective config  file=dist/builder-effective-config.yaml
  • packaging       platform=linux arch=x64 electron=11.4.12 appOutDir=dist/linux-unpacked
  • building        target=snap arch=x64 file=dist/electron-quick-start_1.0.0_amd64.snap
  • default Electron icon is used  reason=application icon is not set
  • application Linux category is set to default "Utility"  reason=linux.category is not set and cannot map from macOS docs=https://www.electron.build/configuration/linux
  ⨯ cannot execute  cause=exit status 1
                    errorOut=/home/om26er/.cache/electron-builder/appimage/appimage-12.0.1/linux-x64/mksquashfs: Compressor "lzo" is not supported!
    /home/om26er/.cache/electron-builder/appimage/appimage-12.0.1/linux-x64/mksquashfs: Compressors available:
        gzip (default)
        xz
@om26er
Copy link
Author

om26er commented Sep 6, 2021

Binary needs to be built with LZO_SUPPORT=1 https://github.com/plougher/squashfs-tools/blob/master/squashfs-tools/Makefile#L51

@om26er
Copy link
Author

om26er commented Sep 13, 2021

ping maintainers, is there a way I could help fix that ?

@develar
Copy link
Member

develar commented Sep 14, 2021

Built with XZ_SUPPORT=1 LZO_SUPPORT=1 ZSTD_SUPPORT=1 GZIP_SUPPORT=0 COMP_DEFAULT=zstd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants