Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Spaces are being replaced with "%20" strings #105

Closed
MarshallOfSound opened this issue Mar 5, 2016 · 6 comments
Closed

Spaces are being replaced with "%20" strings #105

MarshallOfSound opened this issue Mar 5, 2016 · 6 comments

Comments

@MarshallOfSound
Copy link

As per this issue here raised on my repository. MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-#200

The short of it is, for whatever reason the Russian version of Windows 7 (not sure about other versions) doesn't like the % sign in the file name when launching through Update.exe. The problem here is that I didn't put those % signs there, they used to be spaces and this module run some kind of escape over the filename.

Can this behaviour be changed so that these % signs do not appear?

@anaisbetts
Copy link
Contributor

This is a bug in Squirrel.Windows that I need to fix, you can work around it by making sure your executable name doesn't have spaces

@MarshallOfSound
Copy link
Author

@paulcbetts Ah, I wasn't sure which repo was responsible 👍

Is there any way to keep the productName with spaces but have the exe name with spaces?

EDIT: Would I be correct in saying that is what the exe option is for?

@Namynnuz
Copy link

Namynnuz commented Mar 9, 2016

@MarshallOfSound In fact, it's not really a multi-platform way to make spaces in the names (also as some unicode symbols, pretty anything but [a-zA-Z0-9]). All of that %20 instead of space symbol and other percent-encoding stuff is really common in URIs, so it's kinda mandatory to use [a-zA-Z0-9] symbols only (for any multi-platform releases).

@anaisbetts
Copy link
Contributor

All of that %20 instead of space symbol and other percent-encoding stuff is really common in URIs, so it's kinda mandatory to use [a-zA-Z0-9] symbols only (for any multi-platform releases).

No, this is just a stupid bug in Squirrel.Windows that I haven't fixed

@havenchyk
Copy link
Contributor

@paulcbetts will it be handled as a part of Squirrel/Squirrel.Windows#603, Squirrel/Squirrel.Windows#544 and Squirrel/Squirrel.Windows#414?

@havenchyk
Copy link
Contributor

Fixed in squirrel.windows.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants