From 60e173d9aefec3e2c8843507bea3d33158c89262 Mon Sep 17 00:00:00 2001 From: smuthya <59977748+smuthya@users.noreply.github.com> Date: Mon, 27 Jun 2022 10:18:43 -0700 Subject: [PATCH] fix: update dependencies to resolve build issues (#1888) * fix: fix error with ts 4.7.2 version * Removed duplicate 'fetch' variable as it is already defined as a built-in global variable * removed data-reactroot from tests * fix version of cheerio to resolve cannot find module issue Co-authored-by: Srinath Muthyala --- packages/webpack-config-composer/package.json | 2 +- packages/xarc-app-dev/package.json | 2 +- packages/xarc-app-dev/src/lib/dev-admin/log-view.js | 2 +- packages/xarc-react/test/spec/node/index.spec.tsx | 6 ++++-- packages/xarc-subapp/package.json | 2 +- samples/react-jest-app/package.json | 3 ++- samples/stylus-sample/package.json | 3 ++- 7 files changed, 12 insertions(+), 8 deletions(-) diff --git a/packages/webpack-config-composer/package.json b/packages/webpack-config-composer/package.json index d733c7c2f..213b0be5d 100644 --- a/packages/webpack-config-composer/package.json +++ b/packages/webpack-config-composer/package.json @@ -55,7 +55,7 @@ "sinon": "^9.2.2", "sinon-chai": "^3.5.0", "source-map-support": "^0.5.19", - "ts-node": "^9.1.1", + "ts-node": "^10.7.0", "typedoc": "^0.20.13", "typescript": "^4.1.3" }, diff --git a/packages/xarc-app-dev/package.json b/packages/xarc-app-dev/package.json index b161a51b6..84cb08d90 100644 --- a/packages/xarc-app-dev/package.json +++ b/packages/xarc-app-dev/package.json @@ -131,7 +131,7 @@ "sinon": "^9.2.2", "sinon-chai": "^3.5.0", "source-map-support": "^0.5.19", - "ts-node": "^9.1.1", + "ts-node": "^10.7.0", "typedoc": "^0.20.13", "typescript": "^4.1.3" }, diff --git a/packages/xarc-app-dev/src/lib/dev-admin/log-view.js b/packages/xarc-app-dev/src/lib/dev-admin/log-view.js index b8c440cef..e230397fb 100644 --- a/packages/xarc-app-dev/src/lib/dev-admin/log-view.js +++ b/packages/xarc-app-dev/src/lib/dev-admin/log-view.js @@ -1,6 +1,6 @@ /* eslint-disable no-magic-numbers, no-use-before-define, no-unused-vars */ /* eslint-disable no-console, max-statements, no-param-reassign, complexity */ -/* global window, document, EventSource, fetch */ +/* global window, document, EventSource */ // c is from json-formatter-js.js, keep it loaded ahead of log-view.js /* eslint-disable no-undef */ diff --git a/packages/xarc-react/test/spec/node/index.spec.tsx b/packages/xarc-react/test/spec/node/index.spec.tsx index a5d314ed1..fe5af75c8 100644 --- a/packages/xarc-react/test/spec/node/index.spec.tsx +++ b/packages/xarc-react/test/spec/node/index.spec.tsx @@ -19,14 +19,16 @@ describe("createDynamicComponent", function () { expect(container.getNames()).contains("test"); expect(Component).to.be.a("function"); + // data-reactroot isn't getting created due to Context.Provider + // see https://github.com/facebook/react/issues/15012 const html = renderToString(); expect(html).to.equal( - `
subapp test component loading...
` + `
subapp test component loading...
` ); await container.get("test")._getModule(); const html2 = renderToString(); - expect(html2).to.equal(`
hello
`); + expect(html2).to.equal(`
hello
`); }); }); diff --git a/packages/xarc-subapp/package.json b/packages/xarc-subapp/package.json index c5100217b..a0a6fba94 100644 --- a/packages/xarc-subapp/package.json +++ b/packages/xarc-subapp/package.json @@ -76,7 +76,7 @@ "sinon": "^9.2.2", "sinon-chai": "^3.5.0", "source-map-support": "^0.5.19", - "ts-node": "^9.1.1", + "ts-node": "^10.7.0", "typedoc": "^0.20.13", "typescript": "^4.1.3", "xsh": "^0.4.5" diff --git a/samples/react-jest-app/package.json b/samples/react-jest-app/package.json index fbbebea98..22c3db08a 100644 --- a/samples/react-jest-app/package.json +++ b/samples/react-jest-app/package.json @@ -65,7 +65,8 @@ "@xarc/opt-less": "^1.0.2", "@xarc/opt-mocha": "^1.0.0", "@xarc/opt-postcss": "^1.0.4", - "@xarc/opt-stylus": "^1.0.2" + "@xarc/opt-stylus": "^1.0.2", + "cheerio": "=1.0.0-rc.10" }, "fyn": { "dependencies": { diff --git a/samples/stylus-sample/package.json b/samples/stylus-sample/package.json index a3146eb89..4dad8cf5e 100644 --- a/samples/stylus-sample/package.json +++ b/samples/stylus-sample/package.json @@ -53,7 +53,8 @@ "@xarc/opt-karma": "^1.0.0", "@xarc/opt-mocha": "^1.0.0", "@xarc/opt-postcss": "^1.0.0", - "@xarc/opt-stylus": "^1.0.0" + "@xarc/opt-stylus": "^1.0.0", + "cheerio": "=1.0.0-rc.10" }, "fyn": { "dependencies": {