Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use SSRCaching in a project that consumes minimized react-dom modules #32

Open
williamku opened this issue Jun 25, 2019 · 1 comment

Comments

@williamku
Copy link

Hi,

Thanks for providing the SSR caching library! I am tasked to evaluate it to be used in the project I am working on.

Unfortunately I am seeing this error as soon as I included your library in the code:
Error: Cannot find module 'react-dom/lib/ReactCompositeComponent'

It turns out that the project I am working on consumes the minimized 'react-dom' lib directly.

Here is the first line of your library code:
const ReactCompositeComponent = require("react-dom/lib/ReactCompositeComponent");

Here is the structure of "node_modules/react-dom" for the project I am working on:

  • react-dom
    • umd
      • react-dom-server.browser.production.min.js
      • react-dom.production.min.js
      • ... (lots of other files)

As you can see, there isn't a folder named 'lib' hence no module named 'ReactCompositeComponent' either.

Could you kindly let me know how would I use your library for a project that having the 'react-dom' structure like the above?

Many thanks!
William

@Pranab16
Copy link

Hi I am facing the same issue. Please let us know if we can help in resolving this issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants