Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16+ support? #31

Open
adam-26 opened this issue Nov 27, 2017 · 8 comments
Open

React 16+ support? #31

adam-26 opened this issue Nov 27, 2017 · 8 comments

Comments

@adam-26
Copy link

adam-26 commented Nov 27, 2017

Curious if any work has been done to add SSR cache support for React v.16+?

I've created a proof of concept (see: facebook/react#11670) to support SSR plugins with react 16, but maybe alternative solution(s) already exist?

Thanks, Adam.

@jchip
Copy link
Member

jchip commented Nov 27, 2017

we are busy updating all our internal components and apps to React 16 in order to take advantage of the new features and the rewritten SSR engine. We will evaluate if component caching still offers enough benefit with React 16 and if it makes sense to update this module.

@tony99nyr
Copy link

@jchip I am curious what your findings are. We are seeing React 15 with SSR caching significantly faster than React 16 after the first render. ~15ms renders to ~25ms renders and increases CPU usage so our throughput on the same instances is lower.

@s7dhansh
Copy link

any updates on this?

@raphaeleidus
Copy link

Checking back in on this.
The partial caching is a must have for good SSR. I am looking at starting a new project in React 15 to use this library would be great to know if there is a plan for 16 support.

@nakedcity
Copy link

Any update on this one?

@remi5782
Copy link

@nakedcity Tried installing react-dom-core and changing the imports in the ssrCaching.js works
const ReactCompositeComponent = require("react-dom-core/lib/ReactCompositeComponent");
const DOMPropertyOperations = require("react-dom-core/lib/DOMPropertyOperations");
runs without error but the Profile Data is not capturing Can anyone help on this.?

@dtuyenle
Copy link

This won't work using react-dom-core since react-dom 16 not using this module to intercept the rendering hence the intercept won't ever get fired.

@remi5782
Copy link

@dtuyenle that helps thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants