-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 16+ support? #31
Comments
we are busy updating all our internal components and apps to React 16 in order to take advantage of the new features and the rewritten SSR engine. We will evaluate if component caching still offers enough benefit with React 16 and if it makes sense to update this module. |
@jchip I am curious what your findings are. We are seeing React 15 with SSR caching significantly faster than React 16 after the first render. ~15ms renders to ~25ms renders and increases CPU usage so our throughput on the same instances is lower. |
any updates on this? |
Checking back in on this. |
Any update on this one? |
@nakedcity Tried installing react-dom-core and changing the imports in the ssrCaching.js works |
This won't work using react-dom-core since react-dom 16 not using this module to intercept the rendering hence the intercept won't ever get fired. |
@dtuyenle that helps thanks |
Curious if any work has been done to add SSR cache support for React v.16+?
I've created a proof of concept (see: facebook/react#11670) to support SSR plugins with react 16, but maybe alternative solution(s) already exist?
Thanks, Adam.
The text was updated successfully, but these errors were encountered: