Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support? #13

Open
wmertens opened this issue Feb 10, 2017 · 1 comment
Open

Windows support? #13

wmertens opened this issue Feb 10, 2017 · 1 comment

Comments

@wmertens
Copy link

Sorry, not a windows user myself, but I know that you're supposed to use path.join or path.resolve to get valid paths on both Unix and Windows.

I'm thinking that maybe confippet could have a default function root which takes the remaining refs, resolves them, splits them on /, and then uses path.resolve(config.root || process.cwd, ...refs) to generate a valid path on all platforms? So you could e.g. specify paths as icons: '{{root:config.assets:-icons}}'?

I suppose some way to escape : and / in refs would also be necessary.

@jchip
Copy link
Member

jchip commented Jun 7, 2017

I think if dealing with paths correctly on Unix and windows is required, confippet could just use path.normalize for anything that's meant to be a path, and internally keep everything as Unix paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants