feat: Convert waiting
and starting
status to 202
#2161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were returning 503s for anything other than
active
status - for some health check services (like AWS Fargate) you can only rely on the status code, and technically Electric inwaiting
andactive
status is ready to accept requests, just not service them.I've changed it so that:
waiting
andstarting
return 202, requests are accepted and held but failed after a timeout if not activatedactive
returns 200stopping
returns 503, we haven't implemented it yet anywayNot sure if we should consider this a breaking change and how we handle releases at the moment @KyleAMathews .