Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) Fix CI benchmarks #2160

Merged
merged 1 commit into from
Dec 12, 2024
Merged

(chore) Fix CI benchmarks #2160

merged 1 commit into from
Dec 12, 2024

Conversation

robacourt
Copy link
Contributor

Fixes the CI benchmarks by including the newly added where_clause field.

@robacourt robacourt marked this pull request as ready for review December 12, 2024 15:45
msfstef
msfstef approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@msfstef msfstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what I'm looking at but I'm assuming it was just something you forgot!

@robacourt
Copy link
Contributor Author

benchmark this

@electric-sql electric-sql deleted a comment from github-actions bot Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

Benchmark results, triggered for 5546b

  • write fanout completed

write fanout results

  • write fanout completed

write fanout results

  • write fanout completed

write fanout results

@msfstef
Copy link
Contributor

msfstef commented Dec 12, 2024

is this fixed? the action seems to have failed with the same issue

@robacourt robacourt merged commit c2cc76a into main Dec 12, 2024
33 checks passed
@robacourt robacourt deleted the rob/fix-ci-benchmarks branch December 12, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfstef msfstef msfstef approved these changes

@icehaunter icehaunter icehaunter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robacourt @msfstef @icehaunter