Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

append unit to otel attributes #2094

Open
KyleAMathews opened this issue Dec 3, 2024 · 2 comments
Open

append unit to otel attributes #2094

KyleAMathews opened this issue Dec 3, 2024 · 2 comments
Assignees

Comments

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Dec 3, 2024

e.g. for decode_message_duration I don't know if this is ms or (probably) μs

Appending the unit is needed whenever it's ambiguous.

@kevin-dp
Copy link
Contributor

kevin-dp commented Dec 4, 2024

It's in microseconds. I'm not sure about appending the unit. I think it's better to keep it as a number such that we can query using arithmetic operators and perhaps add the unit in the attribute name.

@KyleAMathews
Copy link
Contributor Author

Right yeah, append the unit to the attribute name so decode_message_duration_μs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants