fix: Clean up shape folders and remove unrecoverable shapes #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfstef
force-pushed
the
msfstef/remove-unrecoverable-shape
branch
from
927eb72 to
4702ae4
Compare
magnetised
approved these changes
Nov 27, 2024
|
@magnetised it wouldn't be called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #2049
We are currently leaving folders behind when deleting shapes, which do take up a little bit of space and eventually could be a bit of an issue. This PR takes care of removing everything.
Additionally, when a shape fails to recover by not being able to start the consumer at all (see CubDB issue), the shape data is removed using a new method called
unsafe_cleanup!which simplyrm -rfs the shape directory. Not great to use while the shape is active as it can cause various bugs, but great for cleaning up.