examples: add public deployment of LinearLite #1929
Conversation
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
icehaunter
changed the title
balegas
force-pushed
the
balegas/sst-linearlite
branch
from
aa5bbf6 to
dce24ba
Compare
|
|
||
| - name: Initialize SST environment | ||
| run: | | ||
| sudo apt install -y tini |
There was a problem hiding this comment.
the tini stuff was an experiment I did to see if it'd help sst gracefully shut down (i.e. save it's state correctly when github actions kills it). It didn't seem to work actually so what is needed is concurrency controls so only one action can run at a time & running ones don't get killed.
There was a problem hiding this comment.
Actually looking at the deploy logs — it's already gotten into a bad state because of github killing an action. The "resource already exists" error happens when SST creates a resource but doesn't save it in its state file before getting killed. The only solution is to manually go into aws and remove the resource and try the deploy again.
There was a problem hiding this comment.
yeah. I am trying to figure this out. I thought it could be something I've done locally.
There was a problem hiding this comment.
haha yeah — i've spent a lot of time sorting through this error — you just gotta click around AWS' console looking for the resource(s) mentioned and delete them manually.
Then at the top of file you want:
concurrency:
group: prod-deploy-group
balegas
force-pushed
the
balegas/sst-linearlite
branch
from
ec2f6a5 to
1f68c74
Compare
There was a problem hiding this comment.
Looking great! Excited to see examples go live!
Another nice feature in the future would be posting comments w/ URLs to the sites — there's a good example here: https://github.com/taylorfsteele/TSS/blob/920d33974685280743fce243043099f3d45a4261/.github/workflows/pull-request.yml#L125C2-L168C14
| run: | | ||
| export PR_NUMBER=${{ github.event.number }} | ||
| echo "Removing stage pr-$PR_NUMBER" | ||
| pnpm sst remove --stage "pr-$PR_NUMBER" |
There was a problem hiding this comment.
use $DEPLOY_ENV here to be consistent with other workflow?
| return $interpolate`postgresql://${passwordOutput.roleName}:${passwordOutput.password}@${project.databaseHost}/${db.name}?sslmode=require` | ||
| } | ||
|
|
||
| async function addDatabaseToElectric( |
There was a problem hiding this comment.
fine for now but in a future PR moving all these common helper functions into a common lib would be good
There was a problem hiding this comment.
We should be using hono client!
KyleAMathews
temporarily deployed
to
Pull request
GitHub Actions
Inactive
KyleAMathews
temporarily deployed
to
Pull request
GitHub Actions
Inactive
KyleAMathews
had a problem deploying
to
Pull request
GitHub Actions
Failure
KyleAMathews
had a problem deploying
to
Pull request
GitHub Actions
Failure
KyleAMathews
temporarily deployed
to
Pull request
GitHub Actions
Inactive
Examples |
KyleAMathews
temporarily deployed
to
Pull request
GitHub Actions
Inactive
KyleAMathews
temporarily deployed
to
Pull request
GitHub Actions
Inactive
KyleAMathews
temporarily deployed
to
Pull request
GitHub Actions
Inactive
KyleAMathews
had a problem deploying
to
Pull request
GitHub Actions
Failure
Took changes from #1915 on top of main