Drop all databases on DELETE /v1/admin/databases
#1968
Conversation
| plug :delete_tenant | ||
|
|
||
| defp delete_tenant(conn, _) do | ||
| case TenantManager.delete_all_tenants(conn.assigns.config) do |
There was a problem hiding this comment.
At first glance this looked like it would fail to respond to the HTTP request if the deletion failed.
Looking further i realised that delete_all_tenants will/should always return :ok.
So the case statement seems unnecessary. This would be equivalent:
:ok = TenantManager.delete_all_tenants(conn.assigns.config)
conn
|> send_resp(200, Jason.encode_to_iodata!(%{}))
|> halt()| @@ -2,6 +2,7 @@ defmodule Electric.Plug.RemoveDatabasePlug do | |||
| use Plug.Builder | |||
|
|
|||
| alias Plug.Conn | |||
|
|
|||
| plug :put_resp_content_type, "application/json" | ||
| plug :delete_tenant | ||
|
|
||
| defp delete_tenant(conn, _) do |
There was a problem hiding this comment.
This should be named delete_tenants
|
|
||
| assert conn.status == 200 | ||
|
|
||
| assert Electric.Tenant.Persistence.load_tenants!( |
There was a problem hiding this comment.
Not sure if loading from persistence is the right thing to check here.
I'd check that Electric.TenantManager.get_only_tenant(config) returns {:error, :not_found}
|
Closing as the purpose of this PR is to allow is to allow users of electric (not the cloud) to clear all replication slots so they can permanently stop electric. But since the multi-tenancy separation there is no concept of "all databases" now in electric, there is only one database, so all we need is an endpoint to delete the one database, which I'll do on a separate PR. |
Fixes #1923