-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
largeVis not on CRAN any more #58
Comments
Yes, very unfortunate! |
Guys you can install pretty easily directly from github. That's actually better, because you'll get it optimized for your system. The reason its not on CRAN any longer is that the CRAN build and test system includes an old, commercial C++ compiler for the Solaris platform that has bugs related to C++11 and OpenMP. I can't debug the compilation problem without that compiler, which is not freely available. |
have you explained the problem to the cran maintainers? I don't think they will take down your package if you can't do anything about it. |
No. To be frank what happened is this: the issue came up during the initial submissions, and it was resolved. Then a different maintainer in reviewing the package later removed it. I didn’t see the removal notification until a while after that. At the time, I was planning an update to the package and I figured I’d resolve it then. But I then put the update aside.
Is it really a big deal whether it’s on cran at this point?
… On May 3, 2019, at 12:53 PM, Guido Kraemer ***@***.***> wrote:
have you explained the problem to the cran maintainers? I don't think they will take down your package if you can't do anything about it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
It's up to you if you want to deal with this but being on CRAN will give the package greater visibility. If I am looking for a package to do a certain task, the first thing I usually do is a text search on the CRAN page that lists all the packages. |
The issue is rather dependencies, as I can't put any packages on Bioconductor or CRAN that depend on github largeVis. For example, I was working for a while on a package for custom distance metrics for largeVis (I have given up, it's probably impossible because Rcpp linking across packages / header / etc issues). It would possibly be feasible as a pull request in largeVis, but if the package can't be installed except from CRAN, it will be even less likely that I muster the energy to try this again. |
I also wanted to include this as a method in https://github.com/gdkrmr/dimRed, |
This is unfortunate, precisely because largeVis could easily be added as a dependency to other CRAN or Bioconductor packages if it was on CRAN. Perhaps there's a resolution with the CRAN maintainers? It feels like a shame the package is no longer available due to a rather small issue. |
Alright... I’ll give it a shot this week guys.
… On May 24, 2020, at 7:55 PM, evanbiederstedt ***@***.***> wrote:
This is unfortunate, precisely because largeVis could easily be added as a dependency to other CRAN or Bioconductor packages if it was on CRAN.
Perhaps there's a resolution with the CRAN maintainers?
It feels like a shame the package is no longer available due to a rather small issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
BTW, I'm happy to help out on this front, if it's useful. |
If anyone has a solaris machine, that would be helpful. The issue that arose was a problem during compilation with the commercial Solaris compiler. The package makes extensive use of C++11 and OpenMP, so I've always thought the problem was a bug in that compiler, which I couldn't diagnose because it was commercial. Anyway, what I need to do at this point is to check how the submission requirements have changed, try to compile against them and see if we still have the issue. |
I was thinking Docker images may help us here, but I'm not convinced that's available.
|
Ok I'm getting into this now. If you're still interested in helping, let me know. It looks like the principal thing I need to do is learn what improvements have been made in the R CI testing world (e.g., rhub) since the last time I played with this, and to disentangle any remaining relationship with the |
@elbamos I'm interested---especially as I'm interested in seeing what the cause of the issue was. I'm dealing with this on other fronts. |
@evanbiederstedt If you want to look at the travis configuration, that would be helpful. I can take care of the solaris issue. (If you have a windows machine, I've never tried to get it to compile on Windows, because of the C++11 and OpenMP dependencies. Taking a look at that would also be helpful.) Thanks for nudging me to get back to this. |
Hi,
|
Hi @SamGG thanks! I will ask you to try it again when we get closer to a release. |
My pleasure :-) |
I'm considering dropping DBSCAN and OPTICS from the package. The only advantage to this over the implementations in the dbscan package, is that it takes advantage of the fast nearest neighbor search. And it really complicates things, because they link against the dbscan package. Does anyone think that there are any users of my dbscan or optics implementations? |
Hi @elbamos Thanks again for taking the time to look into this---I'm interested in finding out what's going on.
Sure, I'll make a PR :) |
Concerning DBSCAN and Co, I think you did great improvements that are worth keeping. If you really want to externalize these codes, either propose a PR to the dbscan package, either start another package. That would be a pity if that code would not be easily usable. Data are growing and fast approaches are needed. |
Ok I think I have this worked-out now. Would you folks mind giving a try to the version currently in the |
Hi @elbamos Sorry---I got a bit distracted by life.
I was able to install this directly on Mac OS 10.15.5 with OpenMP configured, using I've been going through the vignettes, where I had no problems. I'm trying the following "larger example" from the vignettes, where
Another question: Have you tried uploading with the CRAN crew? |
https://cran.r-project.org/web/packages/largeVis/
The text was updated successfully, but these errors were encountered: