-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adr-0057: Why we don't use cloud-managed kubernetes services #1001
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @lucianvlad ! This looks really good.
I suspect this ADR will be read quite a lot, so I made a few suggestions on how to make it sound less "meeting notes-y" and more "ADR-y". 😄
docs/adr/0057-why-we-do-not-use-cloud-managed-kubernetes-services.md
Outdated
Show resolved
Hide resolved
docs/adr/0057-why-we-do-not-use-cloud-managed-kubernetes-services.md
Outdated
Show resolved
Hide resolved
## Context and Problem Statement | ||
|
||
Some of our Infra Provider partners offer managed Kubernetes services. | ||
Customers of the self-managed service have already asked why, if they are going to manage the entire stack on a modern cloud (AWS in this case), they can't use the managed Kubernetes control plane to make things easier for them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These managed Kubernetes offerings range from only managing control plane all the way to offering a fully-managed Kubernetes experience.
|
||
Some of our Infra Provider partners offer managed Kubernetes services. | ||
Customers of the self-managed service have already asked why, if they are going to manage the entire stack on a modern cloud (AWS in this case), they can't use the managed Kubernetes control plane to make things easier for them. | ||
We know we have a lot of good reasons for why we don't (loss of fine-grained control, not equivalent offerings means a huge test matrix, etc.), and e.g. bare metal deployments would be impossible if we always assumed a managed Kubernetes Service existing underneath. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rephrase these into decision drivers and move them to the relevant section.
Some of our Infra Provider partners offer managed Kubernetes services. | ||
Customers of the self-managed service have already asked why, if they are going to manage the entire stack on a modern cloud (AWS in this case), they can't use the managed Kubernetes control plane to make things easier for them. | ||
We know we have a lot of good reasons for why we don't (loss of fine-grained control, not equivalent offerings means a huge test matrix, etc.), and e.g. bare metal deployments would be impossible if we always assumed a managed Kubernetes Service existing underneath. | ||
We need to provide solid reasoning toward, in particular, self-managed customers (managed service ones obviously shouldn't have to care how we do what we do). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line can be removed, I'd like the ADR not to sound like meeting notes, but a decision record.
docs/adr/0057-why-we-do-not-use-cloud-managed-kubernetes-services.md
Outdated
Show resolved
Hide resolved
|
||
## Decision Outcome | ||
|
||
Chosen option: 2 - No, and write an ADR to capture the reasons why. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please harmonize with the suggestions above. Also, please follow the original ADR template:
Chosen option: "[option 1]", because [justification. e.g., only option, which meets k.o. criterion decision driver | which resolves force | … | comes out best (see below)].
|
||
### Positive Consequences | ||
|
||
There are several advantages of using installer included in our open source project: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line can be removed to make it sound more "ADR-y". 😄
docs/adr/0057-why-we-do-not-use-cloud-managed-kubernetes-services.md
Outdated
Show resolved
Hide resolved
docs/adr/0057-why-we-do-not-use-cloud-managed-kubernetes-services.md
Outdated
Show resolved
Hide resolved
…ces.md Co-authored-by: Cristian Klein <[email protected]>
…ces.md Co-authored-by: Cristian Klein <[email protected]>
…ces.md Co-authored-by: Cristian Klein <[email protected]>
…ces.md Co-authored-by: Cristian Klein <[email protected]>
…ces.md Co-authored-by: Cristian Klein <[email protected]>
Quality gates: