Optimize bon's generated code typechecking performance and improve error messages #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veetaha
force-pushed
the
feat/optimize-compile-perf
branch
from
0282892 to
3526065
Compare
anelson
approved these changes
Aug 31, 2024
Veetaha
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change yields reduces the compilation time in
frankensteinby 32% (ayrat555/frankenstein#196), although it compromises the readability of the builder signature and rustdoc output. Unfortunately, I haven't found a better way to perseve consice signatures. I posted a question about this on Rustlang Zulip, but no luck so far. I suppose trait/associated-types just suck at performance and we need to live with that.New error messages