Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when tracing is enabled, log the actual json request #589

Merged
merged 1 commit into from
Apr 17, 2014

Conversation

sporty81
Copy link

Was just logging "byte[]" which was no help. This way we can see the command sent to ES. Still doesn't log the response the way it should. Someone need to fix that as well. right now it says "Response stream not captured or already read to completion by serializer" every time for me.

…g "byte[]" which was no help. This way we can see the command sent to ES
@Mpdreamz
Copy link
Member

Hi @sporty81

Thanks for this! Can you sign the Elasticsearch CLA so i can pull your bits in?

http://www.elasticsearch.org/contributor-agreement/

@sporty81
Copy link
Author

OK I filled it out. By the way, in case I do future PRs, are they supposed to be done on a certain branch? Thanks!

@Mpdreamz
Copy link
Member

I try to do big issues/new features in feature/* branches.

I am very lenient when it comes to PR's though, whatever works for you works for me.

I will in the future introduce a stricter git flow workflow for myself but I'm not to worried about where the PR comes from as long as they are opened against the current develop branch (now master might change to develop in the future).

Thanks for signing 👍

@Mpdreamz
Copy link
Member

The only thing I recommend is the EditorConfig visual studio plugin:

http://visualstudiogallery.msdn.microsoft.com/c8bccfe2-650c-4b42-bc5c-845e21f96328

To synchronize indentation and line endings settings per project.

Mpdreamz added a commit that referenced this pull request Apr 17, 2014
when tracing is enabled, log the actual json request
@Mpdreamz Mpdreamz merged commit d2c5bd9 into elastic:master Apr 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants