Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate POST action #10

Open
zubairov opened this issue Jan 15, 2019 · 4 comments
Open

Deprecate POST action #10

zubairov opened this issue Jan 15, 2019 · 4 comments

Comments

@zubairov
Copy link
Contributor

WebHook Action POST should be depricated and phased out. Please use REST API Client instead.

@zubairov
Copy link
Contributor Author

Related issue EIOT-577

@jhorbulyk
Copy link
Contributor

So there are some advantages offered by WebHook POST that aren't yet provided by the REST API Client:

  • Auto-setting of Content-Type and Accept HTTP Headers
  • Setting the body of the call to the incoming message body
  • I can't remember if this component supports sending attachments

@khanzadyan
Copy link
Contributor

My suggestion is to deprecate it. The effort of trying to fix this is probably too much. I've checked in our DB there are 30 active flows which use WebHook post. So we need to add a deprecation flag and leave it like that for some time.

@jhorbulyk
Copy link
Contributor

Item is deprecated. Next step may be to fully remove the action and unrelated dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants