Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateKeys should work as intended from all functions #116

Open
6 tasks
hannah-bulmer opened this issue Nov 11, 2019 · 0 comments
Open
6 tasks

updateKeys should work as intended from all functions #116

hannah-bulmer opened this issue Nov 11, 2019 · 0 comments

Comments

@hannah-bulmer
Copy link

Emitting updateKeys should work as intended when called from

  • verifyCredentials
  • init
  • startup
  • shutdown (?)
  • getMetaModel
  • Select Views functions

Or, if we are not implementing it for a given function, this should be reflected somewhere in the documentation.

The reason for adding this function to all these methods is that there have been cases already where it would have been useful in verifyCredentials and getMetaModel. It makes more sense to add it to all available methods than have to possibly come back to this issue again in the future

See #57 for details regarding implementation for verifyCredentials

For this issue to be resolved

  • ensure updateKeys works as intended in verifyCredentials
  • ensure updateKeys works as intended in init
  • ensure updateKeys works as intended in startup
  • ensure updateKeys works as intended in shutdown
  • ensure updateKeys works as intended in getMetaModel
  • ensure updateKeys works as intended in Select Views
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant