Sailor enhancement: have this.emit() function be defined consistently for all methods called through Sailor

[hannah-bulmer]

The function this.emit() is only properly defined and working as intended in the process function. Either this.emit() should be defined consistently across all the functions Sailor parses, or at the very least there should be clear documentation regarding where this.emit is defined and where it is not.

Discrepancies within this.emit

At the moment, only in process does this.emit() correctly return a Promise.

In verifyCredentials, getMetaModel, and any Select Views function, this.emit() is defined, but is not an async function and does not return a Promise.

In init(), startup(), and shutdown() methods, this.emit() is not defined at all.

Please refer to the image below for more details:

For this issue to be resolved:

• define this.emit for all of the functions above and ensure that it returns a promise (first two columns)
• provide documentation in the Sailor README or elsewhere regarding which functions currently support using this.emit