Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Backward compatibility for older version of Synthetic Monitor #904

Open
doom160 opened this issue Nov 7, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@doom160
Copy link

doom160 commented Nov 7, 2024

Is your feature request related to a problem? Please describe.
Currently I am running older version of Elastic cloud 8.12.2. Currently Im automating the synthetic monitor creation via mastercard rest_api via /internal/synthetics/service/monitors. Noticed that now there are formal support to deploy synthetic monitor and i will want to do so.

Tried and failed with " Not Found%!(EXTRA string=Not Found)" and suspect the code supports only new endpoint which i have checked that it was only available for 8.14 onwards. Since synthetic monitor feature is available for sometime back, will it be possible for backward compatibility for this provider?

https://github.com/biscout42/terraform-provider-elasticstack/blob/28934ed06a28dc1b853815c441ed5ec0dc96e9cf/libs/go-kibana-rest/kbapi/api.kibana_synthetics.go#L15

Describe the resource you would like to have implemented.
elasticstack_kibana_synthetics_monitor

Describe the solution you'd like
To have a check on user's Kibana version, if its <8.14, call the old endpoint, else the current endpoint. There are chances of older ES might have fields mapping changes, i hope its not significant! based on my testing, only max_redirects has changes

Describe alternatives you've considered

  • Stick to my current rest_api way
  • Probably also good to let users know that it only support certain version of ES onwards if there are no plans to support backward compatibility

Additional context
Of course i could have just upgrade my Elasticsearch but my organization is not ready to adopt new version yet.

@doom160 doom160 added the enhancement New feature or request label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant