[Bug] Inconsistency between Kibana SLO API and GO schema

[ntls31]

Describe the bug
There is some inconsistencies between the GO variable schema and the Kibana API to create a SLO, in the "params" settings :

• good is required (set to optional in terraform)
• filter is a string or an object (set to string in terraform)

This inconsistency between the API and Go code leads to an issue when creating a filter which includes a bool query and a KQL query.

Versions:

• Terraform Version : 1.9.7
• Provider version 0.11.9
• Elasticsearch Version : 8.15.2

[tobio]

This inconsistency between the API and Go code leads to an issue when creating a filter which includes a bool query and a KQL query.

@ntls31 do you have an example config reproducing this issue?

[ntls31]

@tobio, here an example of a SLO configuration deployed by the customer working through the kibana API (but not with terraform):

POST kbn:/api/observability/slos
{
  "name": "slo",
  "description": "",
  "indicator": {
    "type": "sli.kql.custom",
    "params": {
      "index": "metrics-*",
      "filter": {
        "filters": [
          {
            "query": {
              "bool": {
                "filter": [
                  {
                    "script": {
                      "script": {
                        "source": "doc['@timestamp'].value.getHour() >= params.startHour && doc['@timestamp'].value.getHour() <= params.endHour",
                        "params": {
                          "startHour": 7,
                          "endHour": 14
                        }
                      }
                    }
                  }
                ]
              }
            },
            "meta": {
              "index": "metrics-*",
              "type": "custom",
              "disabled": false,
              "negate": false,
              "alias": "test"
            }
          }
        ],
        "kqlQuery": "metricset.name : \"state_deployment\""
      },
      "good": """metricset.name : "state_deployment" and kubernetes.deployment.status.available : "true" """,
      "total": """metricset.name : "state_deployment" and kubernetes.deployment.status.available : * """,
      "timestampField": "@timestamp",
      "dataViewId": "xxx"
    }
  },
  "budgetingMethod": "occurrences",
  "timeWindow": {
    "duration": "7d",
    "type": "rolling"
  },
  "objective": {
    "target": 0.99
  },
  "tags": [],
  "groupBy": [
    "*"
  ],
  "settings": {
    "preventInitialBackfill": false
  }
}