Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support adding images for spaces #659

Closed
tehbooom opened this issue Jun 11, 2024 · 1 comment · Fixed by #664
Closed

[Feature] Support adding images for spaces #659

tehbooom opened this issue Jun 11, 2024 · 1 comment · Fixed by #664
Labels
enhancement New feature or request

Comments

@tehbooom
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently the provider can only change the color of spaces. Would like an option to upload images for spaces.

The kibana spaces api supports adding an image with imageUrl

Describe the resource you would like to have implemented.
Add an optional field for image url like we do with color in the elasticstack_kibana_space resource.

Describe the solution you'd like
As of now the go-kibana-rest package does not support an option for the imageUrl. Once the package has this option or we find another way to add that as an option, we would then be able to add an optional field for imageUrl. If imageUrl is specified color cannot be specified.

Describe alternatives you've considered
go-kibana-rest does not seem to be up to date or current with kibana features. I suggest forking this repo, commiting to this repo, or using net/http package to interact with the kibana API since Elastic does not have an SDK for kibana.

@tehbooom tehbooom added the enhancement New feature or request label Jun 11, 2024
@tobio
Copy link
Member

tobio commented Jun 12, 2024

If you were looking to add this yourself, we're already using a local fork of go-kibana-rest since it appears to be abandoned by the maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants