From dbc18d408cf3eb015741ec2f7046c16a91ed4f05 Mon Sep 17 00:00:00 2001
From: mholttech <michael@holtit.com>
Date: Thu, 22 Aug 2024 09:14:17 -0700
Subject: [PATCH] fix elasticstack_kibana_security_role tests

---
 internal/kibana/role_data_source_test.go | 66 ++++++++++++++++++++----
 1 file changed, 56 insertions(+), 10 deletions(-)

diff --git a/internal/kibana/role_data_source_test.go b/internal/kibana/role_data_source_test.go
index 9afa473b2..4b3339858 100644
--- a/internal/kibana/role_data_source_test.go
+++ b/internal/kibana/role_data_source_test.go
@@ -5,10 +5,13 @@ import (
 
 	"github.com/elastic/terraform-provider-elasticstack/internal/acctest"
 	"github.com/elastic/terraform-provider-elasticstack/internal/utils"
+	"github.com/elastic/terraform-provider-elasticstack/internal/versionutils"
+	"github.com/hashicorp/go-version"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 )
 
 func TestAccDataSourceKibanaSecurityRole(t *testing.T) {
+	minSupportedRemoteIndicesVersion := version.Must(version.NewSemver("8.10.0"))
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { acctest.PreCheck(t) },
 		ProtoV6ProviderFactories: acctest.Providers,
@@ -24,6 +27,22 @@ func TestAccDataSourceKibanaSecurityRole(t *testing.T) {
 					utils.TestCheckResourceListAttr("data.elasticstack_kibana_security_role.test", "kibana.0.spaces", []string{"default"}),
 				),
 			},
+			{
+				SkipFunc: versionutils.CheckIfVersionIsUnsupported(minSupportedRemoteIndicesVersion),
+				Config:   testAccDataSourceSecurityRoleRemoteIndices,
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("data.elasticstack_kibana_security_role.test", "name", "data_source_test2"),
+					resource.TestCheckNoResourceAttr("data.elasticstack_kibana_security_role.test", "kibana.0.feature.#"),
+					resource.TestCheckNoResourceAttr("data.elasticstack_kibana_security_role.test", "elasticsearch.0.indices.0.field_security.#"),
+					utils.TestCheckResourceListAttr("data.elasticstack_kibana_security_role.test", "elasticsearch.0.run_as", []string{"elastic", "kibana"}),
+					utils.TestCheckResourceListAttr("data.elasticstack_kibana_security_role.test", "kibana.0.base", []string{"all"}),
+					utils.TestCheckResourceListAttr("data.elasticstack_kibana_security_role.test", "kibana.0.spaces", []string{"default"}),
+					utils.TestCheckResourceListAttr("data.elasticstack_kibana_security_role.test", "elasticsearch.0.remote_indices.0.clusters", []string{"test-cluster"}),
+					utils.TestCheckResourceListAttr("data.elasticstack_kibana_security_role.test", "elasticsearch.0.remote_indices.0.field_security.0.grant", []string{"sample"}),
+					utils.TestCheckResourceListAttr("data.elasticstack_kibana_security_role.test", "elasticsearch.0.remote_indices.0.names", []string{"sample"}),
+					utils.TestCheckResourceListAttr("data.elasticstack_kibana_security_role.test", "elasticsearch.0.remote_indices.0.privileges", []string{"create", "read", "write"}),
+				),
+			},
 		},
 	})
 }
@@ -43,16 +62,43 @@ resource "elasticstack_kibana_security_role" "test" {
 		names = ["sample"]
 		privileges = ["create", "read", "write"]
 	  }
-	// TODO: Move this to version constraint
-	//   remote_indices {
-	//     clusters = ["test-cluster"]
-	//     field_security {
-	//       grant = ["sample"]
-	//       except = []
-	//     }
-	//     names = ["sample"]
-	//     privileges = ["create", "read", "write"]
-	//   }
+	  run_as = ["kibana", "elastic"]
+	}
+	kibana {
+	  base = [ "all" ]
+	  spaces = ["default"]
+	}
+}
+
+data "elasticstack_kibana_security_role" "test" {
+  name = elasticstack_kibana_security_role.test.name
+}
+`
+
+const testAccDataSourceSecurityRoleRemoteIndices = `
+provider "elasticstack" {
+  elasticsearch {}
+  kibana {}
+}
+
+
+resource "elasticstack_kibana_security_role" "test" {
+	name    = "data_source_test2"
+	elasticsearch {
+	  cluster = [ "create_snapshot" ]
+	  indices {
+		names = ["sample"]
+		privileges = ["create", "read", "write"]
+	  }
+      remote_indices {
+	    clusters = ["test-cluster"]
+        field_security {
+          grant = ["sample"]
+          except = []
+        }
+        names = ["sample"]
+        privileges = ["create", "read", "write"]
+      }
 	  run_as = ["kibana", "elastic"]
 	}
 	kibana {