Don't leave the apm_secret_token unknown if we're not adding APM or Integrations Server in the current plan. #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons Server are being added in the current planning phase
dimuon
reviewed
Aug 16, 2023
ec/ecresource/deploymentresource/deployment/v2/use_null_unless_adding_apm_plan_modifier.go
Outdated
Show resolved
Hide resolved
dimuon
reviewed
Aug 16, 2023
ec/ecresource/deploymentresource/deployment/v2/use_null_unless_adding_apm_plan_modifier.go
Outdated
Show resolved
Hide resolved
dimuon
reviewed
Aug 16, 2023
ec/ecresource/deploymentresource/deployment/v2/use_null_unless_adding_apm_plan_modifier.go
Outdated
Show resolved
Hide resolved
dimuon
reviewed
Aug 16, 2023
ec/ecresource/deploymentresource/deployment/v2/use_null_unless_adding_apm_plan_modifier.go
Outdated
Show resolved
Hide resolved
dimuon
reviewed
Aug 16, 2023
…pdates * upstream/master: Update documentation, CHANGELOG.md, and NOTICE Prevent an endless diff loop for deployments with no trust defined (elastic#687) Update documentation, CHANGELOG.md, and NOTICE Set the deployment id in state as soon as it's available to avoid unmanaged resources (elastic#690) Update documentation, CHANGELOG.md, and NOTICE Deployment data source should treat stopped deployments consistently to the deployment resource. (elastic#688) Update documentation, CHANGELOG.md, and NOTICE Update golang.org/x/exp digest to 89c5cff (elastic#685)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's only two cases where the secret token may become populated, that's when APM or Integrations Server resources are created for the first time. All other times we should not leave this attribute as unknown.
Related Issues
Fixes #684
Motivation and Context
How Has This Been Tested?
Manually, unit tests.
Types of Changes
Readiness Checklist