Prevent an endless diff loop for deployments with no trust defined #687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does what it says on the tin. I can't create a deployment in this state, however I've tested the code against the response body of the deployment mentioned in the linked issue.
Null state values are ignored by UseStateForUnknown, which leads to endless diff loops when trust settings are nil.
Related Issues
Fixes #686
Motivation and Context
How Has This Been Tested?
Unit tests, manually
Types of Changes
Readiness Checklist