Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin framework 1.2 #660

Merged
merged 6 commits into from
Jun 16, 2023
Merged

Plugin framework 1.2 #660

merged 6 commits into from
Jun 16, 2023

Conversation

tobio
Copy link
Member

@tobio tobio commented May 30, 2023

Description

Upgrades the plugin framework version

Related Issues

Fixes #607

How Has This Been Tested?

Unit tests, acceptance tests

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@tobio tobio requested a review from dimuon May 30, 2023 12:19
@tobio tobio requested a review from alaudazzi as a code owner May 30, 2023 12:19
@tobio tobio self-assigned this May 30, 2023
@tobio tobio requested a review from a team as a code owner May 30, 2023 12:19
@dimuon
Copy link
Contributor

dimuon commented May 31, 2023

@tobio , thanks a lot for the PR.
Does it make sense to drop CLI 1.3.9 requirement in scope of this PR?

@tobio
Copy link
Member Author

tobio commented May 31, 2023

I was still seeing the same issue running 1.4 in testing IIRC. I'll take another look.

@tobio tobio force-pushed the plugin-framework-1.2 branch from de1c33d to 70407b7 Compare June 1, 2023 01:51
dimuon
dimuon approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks a lot for the PR

@dimuon
Copy link
Contributor

dimuon commented Jun 15, 2023

@tobio , so we cannot yet drop 1.3.9 requirement, right?
It looks like the PR misses changelog :)

@tobio tobio merged commit ea592a1 into elastic:master Jun 16, 2023
@tobio tobio deleted the plugin-framework-1.2 branch June 17, 2023 10:22
@iwahbe iwahbe mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimuon dimuon dimuon approved these changes

@alaudazzi alaudazzi Awaiting requested review from alaudazzi

Assignees

@tobio tobio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider updating dependencies to Plugin Framework v1.1.1
2 participants
@tobio @dimuon