Use the lowest version from a running resource, not just the lowest #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimuon
reviewed
Apr 18, 2023
There was a problem hiding this comment.
@tobio , I suppose this test should fail without the fix (without the fix it should output Error: Provider produced inconsistent result after apply complaining about the version), correct?
|
@tobio , I think both unit and integration tests fail due to changes in core terraform, so if we use an older terraform cli (something like 1.3.9). the tests should pass. Anyway we need to address the issue ASAP but I believe we have also to move to the latest Framework version to handle that correctly. |
|
Yep, I fixed the TF version in #624 to 1.3.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the deployment version determination to filter out stopped resources. The API returns the current plan for resources which have at some point been running, which should not be considered when finding the lowest version.
Related Issues
Fixes #614
How Has This Been Tested?
Updated an existing acceptance test to cover this scenario
Types of Changes
Readiness Checklist