ec_deployment: Add snapshot settings #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
pascal-hofmann
force-pushed
the
ec_deployment-with-snapshots
branch
from
d5814bf to
b3a0a92
Compare
tobio
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Code LGTM. Just need some time to test this one against local ECE. Thanks for these improvements @pascal-hofmann!
|
jenkins test this |
|
@tobio Thanks for the quick review and merge. Is there already a planned release date for 0.7.0? |
|
Not at the moment, there's a couple of other issues on the 0.7 milestone left to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add basic snapshot and snapshot repository configuration to ec_deployment resource.
Related Issues
#602
Motivation and Context
In Elastic Cloud Enterprise snapshot settings can be configured via the ECE UI / REST API. This PR adds the same functionality to the
ec_deploymentresource.How Has This Been Tested?
Types of Changes
Readiness Checklist