Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly capture apm and fleet endpoints as part of the integrations server schema #548

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Explicitly capture apm and fleet endpoints as part of the integrations server schema #548

merged 2 commits into from
Oct 10, 2022

Conversation

tobio
Copy link
Member

@tobio tobio commented Oct 9, 2022

Related Issues

Closes #393

How Has This Been Tested?

Unit test, acceptance tests

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@tobio tobio requested review from webfella and dimuon October 9, 2022 21:58
@tobio tobio self-assigned this Oct 9, 2022
@tobio tobio requested review from alaudazzi, nrichers and a team as code owners October 9, 2022 21:58
webfella
webfella approved these changes Oct 10, 2022
View reviewed changes
Copy link

@webfella webfella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tobio tobio merged commit 2dd81d2 into elastic:master Oct 10, 2022
@tobio tobio deleted the fleet-endpoint branch October 10, 2022 00:10
dimuon pushed a commit to dimuon/terraform-provider-ec that referenced this pull request Feb 2, 2023
@tobio
Explicitly capture apm and fleet endpoints as part of the integration…
101ae61 
…s server schema (elastic#548)

* Explicitly capture apm and fleet endpoints as part of the integrations server schema

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webfella webfella webfella approved these changes

@dimuon dimuon Awaiting requested review from dimuon

@alaudazzi alaudazzi Awaiting requested review from alaudazzi

@nrichers nrichers Awaiting requested review from nrichers

Assignees

@tobio tobio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to capture fleet server endpoint
2 participants
@tobio @webfella