Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the effort and benefits of moving to TF Plugin Framework #506

Closed
d-carmo opened this issue Jun 17, 2022 · 11 comments
Closed

Investigate the effort and benefits of moving to TF Plugin Framework #506

d-carmo opened this issue Jun 17, 2022 · 11 comments
Assignees
Milestone

Comments

@d-carmo
Copy link

d-carmo commented Jun 17, 2022

Overview

Terraform suggests the use of the TF Plugin Framework. We are currently using the API V2.
Lets investigate and see if it is worth to make that move, as well as what is the effort of doing so.

Possible Implementation

Testing

Context

Your Environment

@pascal-hofmann
Copy link
Contributor

Is someone working on this?

I'm currently looking on fixing #336 ad #466 so no matter which blocks you add or remove from your config, it'll always just work without any useless diff. But it looks like this won't be possible without switching to Terraform Plugin Framework.

@dimuon
Copy link
Contributor

dimuon commented Aug 15, 2022

I've started working on this but had to switch to more urgent tasks. I'll return to the ticket once these tasks are done.

@Kushmaro Kushmaro added this to the 0.5.0 milestone Aug 17, 2022
@pascal-hofmann
Copy link
Contributor

@dimuon We decided to work on this as the existing bugs block us. Can you share your current progress?

@dimuon
Copy link
Contributor

dimuon commented Aug 31, 2022

@pascal-hofmann we’re evaluating needed efforts and prioritising it at the moment.

@pascal-hofmann
Copy link
Contributor

Great. So no work is being done twice. :)

-> I've started migrating to framework. The first datasource is nearly working. Will keep you posted on the progress.

@Kushmaro
Copy link
Collaborator

@pascal-hofmann thanks for looking into this!
We're currently also trying to see what's the path to get the provider to use the plugin framework and are also discussing it with Hashicorp.

If you'd like to contribute work along the lines of this issue - we're happy to get help.
But we'll need to balance getting such help with moving as quickly as we can, as this issue is obviously a nuisance to a lot of our customers :)

@pascal-hofmann
Copy link
Contributor

@Kushmaro We just had sprint planning in my team. It was decided that I'll dedicate the next two weeks to migrating terraform-provider-ece to terraform-plugin-framework.

@pascal-hofmann
Copy link
Contributor

Quick status update: The three existing datasources(ec_deployment, ec_deployments, ec_stack) are already working, I'm starting to convert the resources now.

@dimuon
Copy link
Contributor

dimuon commented Sep 6, 2022

@pascal-hofmann , would you mind to share a branch with your changes?

@pascal-hofmann
Copy link
Contributor

Of course. I just pushed it and created a draft PR: #529

I just realized the datasources are not fully done - forgot to work on tests in ec/ecdatasource/deploymentdatasource/datasource_test.go. 🙈

@Kushmaro Kushmaro modified the milestones: 0.5.0, 0.6.0 Oct 18, 2022
@dimuon
Copy link
Contributor

dimuon commented Dec 20, 2022

Closing as completed. The migration is tracked by #530

@dimuon dimuon closed this as completed Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants