ec_deployment_elasticsearch_keystore: Add resource #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick example of what elastic#100 might look like.
Updates the logic to match what the resource should do, in short: Modifies the `create` function to use a hash of the deployment and the setting name. Modifies the `delete` function to unset the value of the keystore so the keystore setting entry is deleted when sent to the `PATCH` api. Simplifies the `expandModel` logic and allows it to `json.Unmarshal` the specified string when it's JSON formatted, otherwise defaults to string. Simplifies the `read` function to lookup the setting name as the key on the returned secrets map and to only reset the ID since the setting does not exist in the backing Elasticsearch cluster anymore. Updates the schema so that when changing the `deployment_id` field, it triggers a re-creation and correctly deletes the previous entry from the previous deployment ID and creates a new entry on the new deployment. Signed-off-by: Marc Lopez Rubio <[email protected]>
Adds an acceptance test that cycles through all the possible states that the resource can go through. Also using the `as_file` field to simulate the case where GCS snapshot credentials are set as a keystore setting. Signed-off-by: Marc Lopez Rubio <[email protected]>
Signed-off-by: Marc Lopez Rubio <[email protected]>
Signed-off-by: Marc Lopez Rubio <[email protected]>
|
Reviewers can use https://registry.terraform.io/tools/doc-preview to verify that the docs display nicely and as intended. |
artemnikitin
approved these changes
Sep 2, 2021
|
@alaudazzi could I have a review on the docs from you folks, please? |
alaudazzi
approved these changes
Sep 10, 2021
Co-authored-by: alaudazzi <[email protected]>
|
Thank you for the suggestions @alaudazzi. Looks much better now. |
|
Failing tests are fixed in #378 |
marclop
deleted the
f/add-ec_deployment_elasticsearch_keystore_setting
branch
marclop
added a commit
to marclop/terraform-provider-ec
that referenced
this pull request
Sep 13, 2021
Adds the missing changelog entry for the change introduced in elastic#364 Signed-off-by: Marc Lopez Rubio <[email protected]>
marclop
added a commit
that referenced
this pull request
Sep 13, 2021
Adds the missing changelog entry for the change introduced in #364 Signed-off-by: Marc Lopez Rubio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
ec_deployment_elasticsearch_keystoreresource which allowsallows creating and updating Elasticsearch keystore settings.
Elasticsearch keystore settings can be created and updated through this
resource, each resource represents a single Elasticsearch Keystore
setting. After adding a key and its secret value to the keystore, you
can use the key name in place of the secret value when you configure
sensitive settings.
This resource offers weaker consistency guarantees and will not detect
and update keystore setting values that have been modified outside of
the scope of Terraform, usually referred to as drift. For instance,
examine the following scenario:
1. A keystore setting is created using this resource.
2. The keystore setting's value is modified to a different value
using the Elasticsearch Service API.
3. Running
terraform applywill fail to detect the changes andwill not update the keystore setting to the value defined in the
terraform configuration.
To force the keystore setting to the value it is configured to hold,
you may want to taint the resource and force its recreation.
Thanks to @karencfv and @Crazybus for the initial work.
Related Issues
Closes #100
How Has This Been Tested?
Manually, unit and acceptance tested.
Types of Changes