Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec_deployments: Add size parameter to data source #300

Merged
merged 3 commits into from
May 5, 2021

Conversation

marclop
Copy link
Contributor

@marclop marclop commented Apr 21, 2021

Description

Adds a new size integer parameter to the ec_deployments data source
which allows users to specify a maximum number of deployments to be
returned. The API defaults to 10 and the provider defaults to 100.

Related Issues

Closes #294

Types of Changes

  • New feature (non-breaking change which adds functionality)

marclop added 2 commits April 21, 2021 14:03
Adds a new `size` integer parameter to the `ec_deployments` data source
which allows users to specify a maximum number of deployments to be
returned. The API defaults to 10 and the provider defaults to `100`.

Signed-off-by: Marc Lopez <[email protected]>
Signed-off-by: Marc Lopez <[email protected]>
@marclop marclop added enhancement New feature or request Team:Delivery labels Apr 21, 2021
@marclop marclop requested a review from neiljbrookes April 21, 2021 09:09
@marclop marclop self-assigned this Apr 21, 2021
@marclop marclop requested review from alaudazzi, nrichers and a team as code owners April 21, 2021 09:09
Signed-off-by: Marc Lopez <[email protected]>
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@neiljbrookes neiljbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marclop this looks great ✅

@marclop marclop merged commit 0c41e2a into elastic:master May 5, 2021
@marclop marclop deleted the f/add-size-param-to-ec_deployments branch May 5, 2021 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ec_deployments : Expose size field for search requests
4 participants