-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sensible defaults for network throttling #284
Comments
Discussed in refinement, and suggested defaults as:
|
Will override options be exposed as heartbeat parameters at any point @andrewvc |
In addition to having defaults, We need to have a add a CLI arg to disable throttling. |
Post FF Testing, i need some help testing, how can we know throttling is being applied? for example i am running like this
So i was expecting in the chrome network tool, throttling will be applied but it still showed no throttling |
You can visit a page or URL with a specific payload size (e.g. a large bitmap image can be good) and compare how long the download takes with different speeds, and also compare to the theoretical download duration based on size and speed. Similarly with upload throttling, POSTing a payload of a particular size. Latency may be harder, as I don’t think you’ll see the impact for example on a SYN/ACK (TCP connection time) with emulated latency in Chrome. It’s a good point about seeing the settings in the devtools UI - not sure if we should expect these to show the settings. That would be useful to confirm the throttling settings have been made. |
Per @vigneshshanmugam, the CDP session set through playwright and the CDP session in the dev tools are actually two different settings, and the devtools does not directly correlate to the CPD session anyway. @vigneshshanmugam Please clarify if I misquoted you. @shahzad31 your best best is tested via the recommended approach from Paul. |
@dominiqueclarke ++. @shahzad31 They are two different instances of CDP session, so the chrome UI would not have any clue on what settings have been applied on the given session in any way. Another way to test would be to check the Network information API on the throttled page https://developer.mozilla.org/en-US/docs/Web/API/NetworkInformation |
Although the more rounded solution for network throttling is defined in #210, this is to at least provide sensible defaults for all monitors.
As a Synthetic user
I want all monitors to run with a sensible network throttling configuration
So that they don’t run at line speed and result in variable performance metrics based on how busy the network is
ACs:
heartbeat.yml
, Fleet Integration)Heartbeat issue here: elastic/beats#27952
The text was updated successfully, but these errors were encountered: