Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

propagate errors from beforeAll and afterAll hooks #280

Closed
vigneshshanmugam opened this issue May 17, 2021 · 1 comment · Fixed by #316
Closed

propagate errors from beforeAll and afterAll hooks #280

vigneshshanmugam opened this issue May 17, 2021 · 1 comment · Fixed by #316
Labels
bug Something isn't working

Comments

@vigneshshanmugam
Copy link
Member

  • Now error in the beforeAll and afterAll hooks would be captured and reported as error, but they will not be associated with the reporters in the correct way.
  • Without associating these errors, the Uptime UI will have no information about what happened during the context of a single execution.

We have to figure out a way to solve this problem.
@vigneshshanmugam vigneshshanmugam added the bug Something isn't working label May 17, 2021
This was referenced May 18, 2021
Closed
Merged
@andrewvc
Copy link
Contributor

andrewvc commented Jun 8, 2021

After discussion we should:

For beforeAll

  1. Catch all errors in beforeAll and hooks
  2. Emit journey/start and journey/end events for all journeys, with the error message + stack trace set as the error in the JSON

For afterAll we will continue with our current behavior for now, simply logging them in heartbeat

@vigneshshanmugam vigneshshanmugam mentioned this issue Jun 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: capture beforeAll hook errors vigneshshanmugam/synthetics
3 participants
@andrewvc @vigneshshanmugam @paulb-elastic