Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for JPEG screenshots #233

Closed
andrewvc opened this issue Mar 1, 2021 · 6 comments · Fixed by #258
Closed

Add option for JPEG screenshots #233

andrewvc opened this issue Mar 1, 2021 · 6 comments · Fixed by #258
Labels
enhancement New feature or request

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Mar 1, 2021

For those who are space conscious JPEG screenshots would be welcome as a CLI option. We would need to add a corresponding heartbeat option.

@andrewvc andrewvc added enhancement New feature or request [zube]: Backlog labels Mar 1, 2021
@vigneshshanmugam
Copy link
Member

Why don't we default to jpeg? Any objection to that using it on the Uptime UI vs the current png type?

@andrewvc
Copy link
Contributor Author

andrewvc commented Mar 1, 2021

@paulb-elastic raised the point that visual diffs, if we choose to use them in the future, don't tend to work as well with jpeg. I'd be inclined to just switch to jpeg for now however, and move to PNG later if we can find value there.

@vigneshshanmugam
Copy link
Member

Yeah i get the visual diff behaviour, but we are not there yet and if we right now aim for the storage space, then jpeg with quality 80 default would be the right choice and would work great for both thumbnail and our full picture in the Uptime UI.

@paulb-elastic
Copy link
Contributor

I’m ok changing this to be the default. Will there be any changes needed to Uptime to support the different format?

Similarly, I would suggest Uptime needs to be able to automatically handle PNG and/or JPEG automatically, for if we do add a PNG option to Synthetics in the future for higher fidelity screenshots for features like visual comparisons.

@andrewvc
Copy link
Contributor Author

andrewvc commented Mar 3, 2021

@paulb-elastic let's do a local change and test it, IIRC we didn't hard code the MIME type, and send it with each request, so we should be good.

@shahidrazam
Copy link

@andrewvc do we updated the JPEG code officially? or any option to do in configuration files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants