Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirects and DNS failures not represented correctly #175

Closed
paulb-elastic opened this issue Dec 17, 2020 · 2 comments · Fixed by #180
Closed

Redirects and DNS failures not represented correctly #175

paulb-elastic opened this issue Dec 17, 2020 · 2 comments · Fixed by #180
Assignees
Labels
bug Something isn't working

Comments

@paulb-elastic
Copy link
Contributor

The waterfall chart is not showing redirects or DNS failure requests correctly. These are implemented differently within the Chrome events, so likely that we are not extracting these requests correctly for storing into ES for displaying on the waterfall chart.

Issues:

  • DNS failures
    • There is a row in the waterfall chart for the domain/request, but no chart data showing the DNS lookup time (which happens to fail)
  • Redirects are not shown at all
    • There is no row in the waterfall chart

image

@vigneshshanmugam
Copy link
Member

The redirect issue is a bug in the agent as we override the record of the event. CDP issues the event with the same request id for both of the redirected request and also the proper request. Will have to do a proper fix.

@vigneshshanmugam
Copy link
Member

For the DNS failure, there is timings.total which should be used instead, Guess that would be fixed along with the squished waterfall PR that @dominiqueclarke is working on. The redirect issue would be fixed by this PR #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants