Report number of GCs #994
Merged
Report number of GCs #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add two new metrics to the command line report to show the number of young and old GCs caused by a benchmark.
danielmitterdorfer
added
enhancement
ebadyano
approved these changes
May 12, 2020
There was a problem hiding this comment.
LGTM! Thank you! @danielmitterdorfer is the idea to eventually report it in our nightly benchmarks?
If we think it's a useful metric for us we can definitely add it. For now my intention was to make use of this for adhoc investigations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add two new metrics to the command line report to
show the number of young and old GCs caused by a benchmark.