-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the release process #993
Conversation
and add troubleshooting tip.
I didn't add a milestone for this on purpose as it's a very minor, internal, item. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments. I think it's ok to have a milestone even if it's just a small thing? It will show up as doc change and I don't think that this would be an issue.
RELEASE.md
Outdated
It is recommended to run `make release-checks release_version=1.2.0 next_version=1.2.1` before the release. The script will check for the requirements mentioned in [Preconditions](#preconditions) and [the Initial setup](#initial_setup). | ||
1. Run release checks to validate requirements mentioned in [Preconditions](#preconditions) and [the Initial setup](#initial_setup) using: | ||
|
||
`make release-checks release_version=2.0.1 next_version=2.0.1` before the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is next_version
intentionally also 2.0.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo, fixed in 4a0c1db
RELEASE.md
Outdated
|
||
This will automatically run all tests (including integration tests), build and upload all artifacts and update the changelog and the list of contributors. | ||
### Example: suppose you want to release Rally 2.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to say Rally 2.0.0? The example where the release
target is invoked suggests that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo fixed in 4a0c1db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the review. |
and add troubleshooting tip.