Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the release process #993

Merged
merged 2 commits into from
May 12, 2020
Merged

Conversation

dliappis
Copy link
Contributor

and add troubleshooting tip.

and add troubleshooting tip.
@dliappis dliappis added :Docs Changes to the documentation cleanup Linter changes, reformatting, removal of unused code etc. labels May 11, 2020
@dliappis dliappis self-assigned this May 11, 2020
@dliappis
Copy link
Contributor Author

I didn't add a milestone for this on purpose as it's a very minor, internal, item.

Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments. I think it's ok to have a milestone even if it's just a small thing? It will show up as doc change and I don't think that this would be an issue.

RELEASE.md Outdated
It is recommended to run `make release-checks release_version=1.2.0 next_version=1.2.1` before the release. The script will check for the requirements mentioned in [Preconditions](#preconditions) and [the Initial setup](#initial_setup).
1. Run release checks to validate requirements mentioned in [Preconditions](#preconditions) and [the Initial setup](#initial_setup) using:

`make release-checks release_version=2.0.1 next_version=2.0.1` before the release.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is next_version intentionally also 2.0.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, fixed in 4a0c1db

RELEASE.md Outdated

This will automatically run all tests (including integration tests), build and upload all artifacts and update the changelog and the list of contributors.
### Example: suppose you want to release Rally 2.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to say Rally 2.0.0? The example where the release target is invoked suggests that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fixed in 4a0c1db

@dliappis dliappis added this to the 2.0.1 milestone May 12, 2020
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dliappis
Copy link
Contributor Author

Thanks for the review.

@dliappis dliappis merged commit 1a69da2 into elastic:master May 12, 2020
@dliappis dliappis deleted the update-release-process branch May 12, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Linter changes, reformatting, removal of unused code etc. :Docs Changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants