Allow to override GC log parameters #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we expose a new telemetry parameter `gc-log-config` that allows users to override the configuration of the GC telemetry device. We only allow to override tags and levels but will still output to a file.
danielmitterdorfer
added
enhancement
hub-cap
approved these changes
May 6, 2020
docs/telemetry.rst
Outdated
| @@ -67,6 +67,15 @@ gc | |||
|
|
|||
| The ``gc`` telemetry device enables GC logs for the benchmark candidate. You can use tools like `GCViewer <https://github.com/chewiebug/GCViewer>`_ to analyze the GC logs. | |||
|
|
|||
| If the runtime JDK is Java 9 or better, the following telemetry parameters can be specified: | |||
There was a problem hiding this comment.
I think or higher or or greater makes more sense than or better here.
There was a problem hiding this comment.
Thanks! I'll change this before I merge.
There was a problem hiding this comment.
Addressed in e4deee5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we expose a new telemetry parameter
gc-log-configthat allows users to override the configuration of the GC telemetry
device. We only allow to override tags and levels but will still output
to a file.