Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable docstring linter check #960

Merged

Conversation

danielmitterdorfer
Copy link
Member

@danielmitterdorfer danielmitterdorfer commented Apr 14, 2020

With this commit we disable a linter check for invalid docstring quotes as this
causes CI failures sometimes but without being reproducible outside of CI.

With this commit we selectively disable a linter check for invalid
docstring quotes as this causes CI failures sometimes but without being
reproducible outside of CI.
@danielmitterdorfer danielmitterdorfer added bug Something's wrong :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Apr 14, 2020
@danielmitterdorfer danielmitterdorfer added this to the 1.5.0 milestone Apr 14, 2020
@danielmitterdorfer danielmitterdorfer self-assigned this Apr 14, 2020
@danielmitterdorfer danielmitterdorfer changed the title Selectively disable docstring linter check Disable docstring linter check Apr 14, 2020
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -42,6 +42,8 @@ def revision():


def version():
# Disabled not because this is an actual issue here but it is occasionally reported by pylint in CI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be exact this is caused by pylint-quotes.

@danielmitterdorfer danielmitterdorfer merged commit cc2296b into elastic:master Apr 14, 2020
@danielmitterdorfer danielmitterdorfer deleted the disable-pylint-check branch April 14, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's wrong :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants