Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an override for the rally homedir #945

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Conversation

hub-cap
Copy link
Contributor

@hub-cap hub-cap commented Apr 1, 2020

No description provided.

@hub-cap hub-cap added the :misc Changes that don't affect users directly: linter fixes, test improvements, etc. label Apr 1, 2020
@hub-cap hub-cap added this to the 1.5.0 milestone Apr 1, 2020
@hub-cap hub-cap requested a review from dliappis April 1, 2020 17:02
@hub-cap hub-cap self-assigned this Apr 1, 2020
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but wait until CI is green before merging ofc)

@@ -21,6 +21,7 @@ passenv =
JAVA12_HOME
JAVA13_HOME
SSH_AUTH_SOCK
OVERRIDE_RALLY_HOME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe in alphanum order here?

@hub-cap
Copy link
Contributor Author

hub-cap commented Apr 1, 2020

@elasticmachine run tests

@hub-cap hub-cap merged commit 012bbb0 into elastic:master Apr 1, 2020
@hub-cap hub-cap deleted the override_home branch April 1, 2020 18:11
@danielmitterdorfer danielmitterdorfer added the enhancement Improves the status quo label Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants