Fix request timeout handling #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we address several issues in request timeout handling: 1. We ensure that the end of the request is properly measured 2. We set an explicit request timeout on the connection to avoid that the default connection timeout is picked. 3. We use the proper method parameter `timeout` when falling back to the raw transport API instead of setting the ineffective parameter `request_timeout`.
danielmitterdorfer
added
bug
dliappis
approved these changes
Apr 1, 2020
| if max_num_segments: | ||
| await es.transport.perform_request("POST", "/_optimize?max_num_segments={}".format(max_num_segments), | ||
| params=params) | ||
| await es.transport.perform_request("POST", f"/_optimize?max_num_segments={max_num_segments}", |
There was a problem hiding this comment.
And so it begins (f-strings in the codebase) :)
|
Thanks for the review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we address several issues in request timeout handling:
the default connection timeout is picked.
timeoutwhen falling back to theraw transport API instead of setting the ineffective parameter
request_timeout.