Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume a TTY for interactive commands #923

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

danielmitterdorfer
Copy link
Member

With this commit we assume that Rally is attached to a TTY when an
interactive command is invoked and are only defensive in actors. This
change allows Rally to produce output even when it is redirected to a
file or used in shell pipelines.

With this commit we assume that Rally is attached to a TTY when an
interactive command is invoked and are only defensive in actors. This
change allows Rally to produce output even when it is redirected to a
file or used in shell pipelines.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Usability Makes Rally easier to use labels Mar 2, 2020
@danielmitterdorfer danielmitterdorfer added this to the 1.5.0 milestone Mar 2, 2020
@danielmitterdorfer danielmitterdorfer self-assigned this Mar 2, 2020
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@danielmitterdorfer danielmitterdorfer merged commit a6f514b into elastic:master Mar 3, 2020
@danielmitterdorfer danielmitterdorfer deleted the assume-tty branch March 3, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :Usability Makes Rally easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants