Use zeros instead of whitespaces as padding bytes #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drawlerr
added
bug
jpountz
approved these changes
Feb 14, 2020
|
Arrg. Seems we've managed to coax out an unrelated race condition in Rally during the integration test. I've written this up in #900, but for now I'm just going to run tests again as we shouldn't be unlucky enough to hit it twice in a row: @elasticsearchmachine run tests |
|
@elasticmachine test this please |
danielmitterdorfer
added
the
:Load Driver
danielmitterdorfer
requested changes
Feb 17, 2020
There was a problem hiding this comment.
Thanks for changing this. I'm fine with the actual change but:
- IMHO this is a breaking change: We should label it as such and add a small note to your migration docs.
- I don't think this is a bug but rather an enhancement?
- Once merged, can you please keep an eye on all our update-related workloads as their performance might be impacted by this change? If this is the case, can you please add an according annotation?
drawlerr
added
enhancement
|
Woohoo |
tomcallahan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is more realistic to use 0-padding than whitespace padding in IDs, and this is the format Elasticsearch prefers anyways.
Applying @jpountz 's patch for ID generation, fixing associated tests.
Closes #896