Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only keep the most recent build log #832

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Only keep the most recent build log #832

merged 1 commit into from
Dec 2, 2019

Conversation

danielmitterdorfer
Copy link
Member

With this commit we continously override a potentially existing
Elasticsearch build log. Keeping a history of build logs is not
necessary as it is only relevant to investigate on failures. Thus a
history only adds complexity (e.g. log rotation setup) for little value.

Relates #818

@danielmitterdorfer
Only keep the most recent build log
da4941e 
With this commit we continously override a potentially existing
Elasticsearch build log. Keeping a history of build logs is not
necessary as it is only relevant to investigate on failures. Thus a
history only adds complexity (e.g. log rotation setup) for little value.

Relates elastic#818
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch labels Nov 29, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.4.0 milestone Nov 29, 2019
@danielmitterdorfer danielmitterdorfer self-assigned this Nov 29, 2019
dliappis
dliappis reviewed Dec 2, 2019
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this makes sense. As things are now build.log is also not useful for investigations either as there are no timestamps.

One question mark is investigating build failures for nightlies, as subsequent runs will overwrite this file.

@dliappis dliappis self-requested a review December 2, 2019 09:39
dliappis
dliappis approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Nightlies can have this problem mitigated by not building when a configuration changes, but right at the beginning which makes diagnosing easier.

@danielmitterdorfer
Copy link
Member Author

Thanks for the review! :)

@danielmitterdorfer danielmitterdorfer merged commit 8cc4f4b into elastic:master Dec 2, 2019
@danielmitterdorfer danielmitterdorfer deleted the most-recent-build-counts branch December 2, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees

@danielmitterdorfer danielmitterdorfer

Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch enhancement Improves the status quo
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmitterdorfer @dliappis