Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade psutil to work with newer linux kernels #820

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

hub-cap
Copy link
Contributor

@hub-cap hub-cap commented Nov 18, 2019

The 4.18 kernel introduced a number of new fields into the disk io stats
proc fileystem, and running tests on new versions of linux is causing
failures because psutil cannot interpret the new fields. This fix
updates the version such that it works w/ newer kernels.

Relates giampaolo/psutil#1354

The 4.18 kernel introduced a number of new fields into the disk io stats
proc fileystem, and running tests on new versions of linux is causing
failures because psutil cannot interpret the new fields. This fix
updates the version such that it works w/ newer kernels.

Relates giampaolo/psutil#1354
@hub-cap
Copy link
Contributor Author

hub-cap commented Nov 18, 2019

As this is my first PR, I know very little about proper labeling procedures, as well as what I would do to test this change to ensure that the upgrade did not cause a significant change in benchmarks.

@danielmitterdorfer danielmitterdorfer added the :misc Changes that don't affect users directly: linter fixes, test improvements, etc. label Nov 19, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.4.0 milestone Nov 19, 2019
@danielmitterdorfer danielmitterdorfer added the bug Something's wrong label Nov 19, 2019
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. LGTM

@hub-cap hub-cap merged commit b043783 into elastic:master Nov 20, 2019
@hub-cap hub-cap deleted the upgrade_psutil branch November 20, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's wrong :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants