Allow multiple nodes per IP #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we expose a new provisioner variable `all_node_names` which consists of all Elasticsearch node names in the cluster. This can be used to set `cluster.initial_master_nodes` in order to ensure the discovery process takes all nodes into account even if they are started on the same host. Previously we have used the IP address for this purpose but this is ambiguous when multiple nodes are started on the same host.
danielmitterdorfer
added
bug
danielmitterdorfer
added a commit
to danielmitterdorfer/rally-teams
that referenced
this pull request
Oct 28, 2019
With this commit we use the Elasticsearch node name instead of its IP to configure `cluster.initial_master_nodes`. This avoids any ambiguity in case multiple nodes are configured per host. For backwards-compatibility we fallback to previous behavior if the template variable `all_node_names` is undefined. Relates elastic/rally#804
|
Note: This requires elastic/rally-teams#34 to work as intended. |
|
Should we add anything to the documentation at all to mention that starting with multiple nodes on same ip address is possible now? |
Actually this was always meant to be possible and in fact multiple nodes also start up on a single host. The problem was that the nodes did not form a cluster due to misconfigured discovery settings in that case. |
|
makes sense, thank you! |
|
Thanks for your review! :) |
danielmitterdorfer
added a commit
to elastic/rally-teams
that referenced
this pull request
Oct 28, 2019
With this commit we use the Elasticsearch node name instead of its IP to configure `cluster.initial_master_nodes`. This avoids any ambiguity in case multiple nodes are configured per host. For backwards-compatibility we fallback to previous behavior if the template variable `all_node_names` is undefined. Relates elastic/rally#804 Relates #34
danielmitterdorfer
added a commit
to elastic/rally-teams
that referenced
this pull request
Oct 28, 2019
With this commit we use the Elasticsearch node name instead of its IP to configure `cluster.initial_master_nodes`. This avoids any ambiguity in case multiple nodes are configured per host. For backwards-compatibility we fallback to previous behavior if the template variable `all_node_names` is undefined. Relates elastic/rally#804 Relates #34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we expose a new provisioner variable
all_node_nameswhich consists of all Elasticsearch node names in the cluster. This can
be used to set
cluster.initial_master_nodesin order to ensure thediscovery process takes all nodes into account even if they are started
on the same host. Previously we have used the IP address for this
purpose but this is ambiguous when multiple nodes are started on the
same host.