Whitelist py.test in tox tests #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a binary is not installed via tox, it will emit the following warning: ``` WARNING: test command found but not installed in testenv cmd: /Users/daniel/Projects/rally/.venv/bin/py.test env: /Users/daniel/Projects/rally/.tox/py37 Maybe you forgot to specify a dependency? See also the whitelist_externals envconfig setting. DEPRECATION WARNING: this will be an error in tox 4 and above! ``` With this commit we exclude `py.test` from this check by specifying it in `whitelist_externals`. This is ok since we ensure that this binary is installed via our configuration in `setup.py` and thus we can avoid this warning.
danielmitterdorfer
added
enhancement
|
Thanks for the review! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a binary is not installed via tox, it will emit the following
warning:
With this commit we exclude
py.testfrom this check by specifying itin
whitelist_externals. This is ok since we ensure that this binary isinstalled via our configuration in
setup.pyand thus we can avoid thiswarning.